LATX, fix: Ignore segment bases in LEA - #429
Merged
Merged
Conversation
LEA computes an effective offset and must not apply FS or GS segment bases. The shared memory-address conversion path added the segment base and corrupted IDTest's embedded resource copy. Copy the operand and clear its segment before lowering the address. Signed-off-by: Wenqiang Wei <weiwenqiang@mail.ustc.edu.cn>
xiezyang
approved these changes
Aug 31, 2026
xiezyang
left a comment
xiezyang
left a comment
Contributor
There was a problem hiding this comment.
LGTM。该修改符合 LEA 忽略 FS/GS 段基址的语义，保留了通用寄存器地址计算和地址位宽处理，同时避免了错误加入段基址。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LEA computes an effective offset and must not apply FS or GS segment bases. The shared memory-address conversion path added the segment base and corrupted IDTest's embedded resource copy.
Copy the operand and clear its segment before lowering the address.
Summary / 变更说明
Validation / 验证
Checklist / 检查项
CONTRIBUTING.md. / 我已阅读CONTRIBUTING.md。git commit -s). /每个提交都包含 DCO 签署（
git commit -s）。are not applicable. /
我已提供相关构建或测试结果，或说明了不适用的原因。