Skip to content

linux-user, fix: Preserve x87 state in signal frames #423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LaurenIsACoder merged 1 commit into from
Aug 27, 2026
Merged

linux-user, fix: Preserve x87 state in signal frames #423

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions linux-user/i386/signal.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -471,15 +471,21 @@ cs->previous_exception_index = -1;
__put_user(env->regs[R_ESP], &sc->esp_at_signal);
__put_user(env->segs[R_SS].selector, (unsigned int *)&sc->ss);

cpu_x86_fsave(env, fpstate_addr, 1);
fpstate->status = fpstate->sw;
if (!(env->features[FEAT_1_EDX] & CPUID_FXSR)) {
magic = 0xffff;
} else {
/*
* cpu_x86_fsave() has FSAVE semantics and resets the x87 state.
* Capture the non-destructive extended state first, then let FSAVE
* fill the legacy area and initialize the state used by the handler.
* Sigreturn restores the interrupted state from the signal frame.
*/
xsave_sigcontext(env, &fpstate->fxsave,
fpstate_addr + TARGET_FPSTATE_FXSAVE_OFFSET);
magic = 0;
}
cpu_x86_fsave(env, fpstate_addr, 1);
fpstate->status = fpstate->sw;
__put_user(magic, &fpstate->magic);
#else
__put_user(env->regs[R_EDI], &sc->rdi);
Expand Down