Repository navigation
fix(github datasource): skip blocked repositories when listing pages - #4217
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
There are no active review issues for the blocked-repository handling and concurrent page-loading changes.
No open issues 🎉
What changed in this PR
Improves GitHub datasource page listing by skipping blocked repositories and reducing request latency while preserving repository order.
Changes:
- Treat non-rate-limit 403 responses as errors; skip blocked repositories and log their block reason.
- Load repository pages using a bounded five-worker pool.
- Add regression tests for error handling and blocked-repository skipping, and bump the plugin version to
0.4.11.
| File | Description |
|---|---|
datasources/github/tests/test_github.py |
Tests 403 handling, blocked-repository skipping, and page order. |
datasources/github/manifest.yaml |
Bumps the plugin version to 0.4.11. |
datasources/github/datasources/github.py |
Adds blocked-repository handling and concurrent page loading. |
Review effort: Balanced
hyoban
approved these changes
Nov 6, 2026
hyoban
had a problem deploying
to
datasources/github
November 6, 2026 10:30 — with
GitHub Actions
Failure
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Repository access blocked, and log the repository and block reason while continuing to list accessible repositories.0.4.11.Release Notes
Context
The authenticated repository list can include a repository whose README endpoint returns HTTP 403 with
block.reason: tosand a nonzero rate limit balance. Version0.4.10treats that response as successful JSON and then raisesKeyError: 'path'. The sequential README, Issues, and PR requests also caused the page-list operation to exceed the upstream request timeout in the observed production case.Change Type
Version
versioninmanifest.yamlto0.4.11.Verification
uv run --python 3.12 --frozen --with pytest python -m pytest tests/test_github.py -q(3 passed)git diff --checkThe regression tests cover a blocked repository, another non-rate-limit 403, an actual rate-limit 403, and accessible repositories before and after a blocked one.