Closed
Conversation
added 4 commits
February 5, 2019 22:21
…pshot-backup-logic
ghost
mentioned this pull request
Author
|
I think @cognoquest has a better approach for this feature with his pull request #167 I'll review his pull request in the next days. |
Author
|
Closing this as i moved on to Proxmox |
ghost
closed this
ghost
deleted the
change-shutdown-snapshot-backup-logic
branch
January 15, 2021 23:34
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I moved the block powering back on a VM with POWER_VM_DOWN_BEFORE_BACKUP=1 right above the actual backup takes place to shorten the downtime. Also made sure that such VMs are snapshotted too (otherwise it wouldn't work).
While i was here i documented the -e parameter and corrected some indentation (most of it was auto-corrected by Atom editor).
I ran a few tests and they worked for me so far. I will use this version on an internal production server starting 2/12/2019 and report back after the first backup runs were made.
My intention to make this change are database servers and Windows domain controllers to ensure a clean ("cold") backup in a guaranteed clean state while keeping downtimes still short.