Skip to content

tests/e2e/scalability: configure watch progress notify interval for scale clusters - #18842

Merged
kubernetes-prow[bot] merged 1 commit into
kubernetes:masterfrom
Jefftree:5k-etcd-progress-notify
Oct 10, 2026
Merged

kubernetes-prow[bot] merged 1 commit into
kubernetes:masterfrom
Jefftree:5k-etcd-progress-notify

Conversation

@Jefftree

@Jefftree Jefftree commented Oct 9, 2026 •

Copy link
Copy Markdown
Member

What this PR does / why we need it:
Configure etcd watch progress notify interval for scalability clusters, defaulting to 5s.

Metric Baseline GCE-100 Run PR #18842 GCE-100 Run Delta
Total Etcd Bookmarks 3,954 21,681 +448.3%
WatchCacheLag P90 18.18s 2.84s -84.4%
WatchCacheLag P99 36.19s 6.63s -81.7%
WatchCacheLag Max 38.43s 7.17s -81.3%

@kubernetes-prow kubernetes-prow Bot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 9, 2026
@michaelasp

Copy link
Copy Markdown
Contributor

/lgtm

@kubernetes-prow kubernetes-prow Bot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 9, 2026
@Jefftree
Jefftree force-pushed the 5k-etcd-progress-notify branch from c718687 to 90f188a Compare October 9, 2026 18:17
@kubernetes-prow kubernetes-prow Bot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 9, 2026
create_args+=("--set spec.etcdClusters[*].manager.env=ETCD_ENABLE_PPROF=true")
if [[ -n "${ETCD_PROGRESS_NOTIFY_INTERVAL}" ]]; then
create_args+=("--set spec.etcdClusters[*].manager.env=ETCD_WATCH_PROGRESS_NOTIFY_INTERVAL=${ETCD_PROGRESS_NOTIFY_INTERVAL}")
create_args+=("--set spec.etcdClusters[*].manager.env=ETCD_EXPERIMENTAL_WATCH_PROGRESS_NOTIFY_INTERVAL=${ETCD_PROGRESS_NOTIFY_INTERVAL}")

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure you can set both. --experimental- prefix was just etcd <=v3.6, etcd v3.7 just uses normal without prefix

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated. Needed to change kubernetes/test-infra#38031

@Jefftree
Jefftree force-pushed the 5k-etcd-progress-notify branch from 90f188a to 9526a0a Compare October 9, 2026 18:24
@Jefftree
Jefftree force-pushed the 5k-etcd-progress-notify branch from 9526a0a to 9f716d2 Compare October 9, 2026 18:26
@Jefftree

Jefftree commented Oct 9, 2026

Copy link
Copy Markdown
Member Author

/hold

For verification.

@kubernetes-prow kubernetes-prow Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 9, 2026
@Jefftree

Jefftree commented Oct 9, 2026 •

Copy link
Copy Markdown
Member Author

/unhold

Confirmed bookmarks are being sent every 5s in the 100-node run.

@kubernetes-prow kubernetes-prow Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 9, 2026
@serathius

Copy link
Copy Markdown
Member

/lgtm
/approve

@kubernetes-prow kubernetes-prow Bot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 10, 2026
@kubernetes-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow kubernetes-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 10, 2026
@kubernetes-prow
kubernetes-prow Bot merged commit 311ded3 into kubernetes:master Oct 10, 2026
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants