Repository navigation
tests/e2e/scalability: configure watch progress notify interval for scale clusters - #18842
Merged
kubernetes-prow[bot] merged 1 commit intoOct 10, 2026
Merged
Conversation
Contributor
|
/lgtm |
Jefftree
force-pushed
the
5k-etcd-progress-notify
branch
from
October 9, 2026 18:17
c718687 to
90f188a
Compare
serathius
reviewed
Oct 9, 2026
| create_args+=("--set spec.etcdClusters[*].manager.env=ETCD_ENABLE_PPROF=true") | ||
| if [[ -n "${ETCD_PROGRESS_NOTIFY_INTERVAL}" ]]; then | ||
| create_args+=("--set spec.etcdClusters[*].manager.env=ETCD_WATCH_PROGRESS_NOTIFY_INTERVAL=${ETCD_PROGRESS_NOTIFY_INTERVAL}") | ||
| create_args+=("--set spec.etcdClusters[*].manager.env=ETCD_EXPERIMENTAL_WATCH_PROGRESS_NOTIFY_INTERVAL=${ETCD_PROGRESS_NOTIFY_INTERVAL}") |
Member
There was a problem hiding this comment.
Not sure you can set both. --experimental- prefix was just etcd <=v3.6, etcd v3.7 just uses normal without prefix
Member
Author
There was a problem hiding this comment.
Updated. Needed to change kubernetes/test-infra#38031
Jefftree
force-pushed
the
5k-etcd-progress-notify
branch
from
October 9, 2026 18:24
90f188a to
9526a0a
Compare
Jefftree
force-pushed
the
5k-etcd-progress-notify
branch
from
October 9, 2026 18:26
9526a0a to
9f716d2
Compare
Member
Author
|
/hold For verification. |
Member
Author
|
/unhold Confirmed bookmarks are being sent every 5s in the 100-node run. |
Member
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: serathius The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Configure etcd watch progress notify interval for scalability clusters, defaulting to 5s.