Skip to content

stderrthreshold not honored when logtostderr is set #212

Description

@aramase

/kind bug

What steps did you take and what happened:
[A clear and concise description of what the bug is.]
We're using the klog logging framework in Secrets Store CSI Driver. When trying to set -stderrthreshold=ERROR with -logtostderr=true, we're seeing all the logs are being printed. Is this the expected behavior?

Users want to only log the ERROR but that doesn't seem like an option today? Is there any configuration that we're missing.

cc @tam7t

What did you expect to happen:

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

Activity

  1. aramase commented on Feb 11, 2021

    @aramase
    MemberAuthor

    Found this PR (#31) which adds the severity check when logtostderr is set. This was however reverted #50

  2. pierluigilenoci commented on Feb 24, 2021

    @pierluigilenoci
    Member

    @pohly @dims could you please take a look?

  3. pierluigilenoci commented on Feb 25, 2021

    @pierluigilenoci
    Member

    @DirectXMan12 @justinsb @neolit123 @mtaufen could you please take a look?

  4. pierluigilenoci commented on Mar 4, 2021

    @pierluigilenoci
    Member

    @pohly @yuzhiquan @munnerz could you please take a look?

  5. pierluigilenoci commented on Mar 4, 2021

    @pierluigilenoci
    Member
  6. lavalamp commented on Mar 4, 2021

    @lavalamp

    Everyone is extremely overloaded. This looks like it may be much more important to you than perhaps to some other people.

    The description of the reversion PR is pretty clear about what went wrong. I recommend sending a PR that adds what you need while not triggering the problems mentioned there.

  7. pierluigilenoci commented on Mar 9, 2021

    @pierluigilenoci
    Member

    @lavalamp I can understand that you are all loaded with work but this seems a pretty big bug for a logging library and it seems incredible to me that in two years no one has been able to fix it.

  8. dims commented on Mar 9, 2021

    @dims
    Member

    @pierluigilenoci please re-read exactly what @lavalamp said. that's what you will hear from any one of us. good luck!

  9. fejta-bot commented on Jun 7, 2021

    @fejta-bot

    Issues go stale after 90d of inactivity.
    Mark the issue as fresh with /remove-lifecycle stale.
    Stale issues rot after an additional 30d of inactivity and eventually close.

    If this issue is safe to close now please do so with /close.

    Send feedback to sig-contributor-experience at kubernetes/community.
    /lifecycle stale

  10. added
    lifecycle/staleDenotes an issue or PR has remained open with no activity and has become stale.
    on Jun 7, 2021
  11. pierluigilenoci commented on Jun 8, 2021

    @pierluigilenoci
    Member

    /remove-lifecycle stale

  12. removed
    lifecycle/staleDenotes an issue or PR has remained open with no activity and has become stale.
    on Jun 8, 2021
  13. deyanp commented on Jul 28, 2021

    @deyanp

    @lavalamp @dims any chance to get the PR of @pierluigilenoci approved? Sorry for jumping in, but I am affected by a pod for Azure AKS which is using this library and generating high log storage costs per month ...

  14. dims commented on Jul 28, 2021

    @dims
    Member

    @deyanp this is configurable from the command line as well as programatically, so sorry i don't see why the application developer using this library is unable to set this in one of those ways? can you please explain more?

  15. 189 remaining items

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    kind/featureCategorizes issue or PR as related to a new feature.lifecycle/frozenIndicates that an issue or PR should not be auto-closed due to staleness.

    Type

    No type

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions