Repository navigation
Conversation
Signed-off-by: xinjun.jiang <xinjun.jiang@daocloud.io>
Signed-off-by: xinjun.jiang <xinjun.jiang@daocloud.io>
git-jxj
force-pushed
the
docs/fix-python-rayjob-submission-example-20261002
branch
from
October 28, 2026 06:34
b673964 to
beffcd7
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
The Python client README calls
submit_jobon thekuberay_job_apimodule, which raisesAttributeError; the method belongs toRayjobApi. The example also contains an unserializable metadata placeholder, an undefined namespace, and apython -ccommand that tries to evaluate a filename.Instantiate
RayjobApiand provide a concrete job name, namespace, and executable entrypoint. Explain how to select an existing cluster in another namespace. Keep the example compatible with the renamedkuberay_clientpackage.Related issue number
N/A — correction to the existing RayJob submission example.
Labels
doc-updates-requiredlabel.breaking-changelabel.AI assistance
Yes. AI assisted with the documentation changes and testing.
Checks
Manual test instructions
Executed the README snippet through the real Python client with Kubernetes server-side dry-run and validated the job body against the current RayJob CRD schema. Executed the example entrypoint locally (output:
2). Ran markdownlint 0.44.0 with the repository configuration and the applicable whitespace/file pre-commit checks. This does not run a RayJob or a Ray cluster.