Skip to content

update model catalog settings microcopy for HF sources - #3246

Merged
google-oss-prow[bot] merged 4 commits into
kubeflow:mainfrom
ConorOM1:micro_hf
Sep 17, 2026
Merged

update model catalog settings microcopy for HF sources#3246
google-oss-prow[bot] merged 4 commits into
kubeflow:mainfrom
ConorOM1:micro_hf

Conversation

@ConorOM1

@ConorOM1 ConorOM1 commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

Description

Addresses post UX review of microcopy for private/gated Hugging Face model catalog settings and related UI strings.

Note: Source disabled micro update is handled in #3192

How Has This Been Tested?

Manual UI verification in dev mode (cd clients/ui && make dev-start):

  • Access token / Organization popovers
  • Validate success (Organization: Google, any token)
  • Validate error (Organization: qwen, any token — mock catalog client returns 401)
  • Clear token modal after successful validation
  • Gated preview alert after Preview with gated models in source
  • Included models description under Model visibility
  • npm run test:type-check
  • Unit tests updated: PreviewPanel.spec.tsx, hfAccessUtils.spec.ts

Org popover
image

Token popover
image

validate success
image

validate error
image

clear token
image

gated alert
image

included models description
image

Merge criteria:

  • All the commits have been signed-off (To pass the DCO check)
  • The commits have meaningful messages
  • Automated tests are provided as part of the PR for major new functionalities; testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work.
  • Code changes follow the kubeflow contribution guidelines.
  • For first time contributors: Please reach out to the Reviewers to ensure all tests are being run, ensuring the label ok-to-test has been added to the PR.

If you have UI changes

  • The developer has added tests or explained why testing cannot be added.
  • Included any necessary screenshots or gifs if it was a UI change.
  • Verify that UI/UX changes conform the UX guidelines for Kubeflow.

@ConorOM1
micro updates
ff9d812 
Signed-off-by: Conor O'Malley <conormomalley@gmail.com>
@ppadti

ppadti commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

/ok-to-test

@ppadti

ppadti commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

/retest

ConorOM1 and others added 2 commits September 17, 2026 13:17
@ConorOM1
Merge branch 'main' into micro_hf
98f40b8 
Signed-off-by: Conor O'Malley <97108400+ConorOM1@users.noreply.github.com>
@ConorOM1
lint fix dupe
aca330a 
Signed-off-by: Conor O'Malley <conormomalley@gmail.com>
ppadti
ppadti suggested changes Sep 17, 2026
View reviewed changes
Comment thread clients/ui/frontend/src/app/pages/modelCatalogSettings/constants.tsx

export const HELPER_TEXT = {
YAML: 'Upload or paste a YAML string.',
ORGANIZATION_SLUG:

@ppadti ppadti Sep 17, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The organization help text needs to be changed to "Case-sensitive. Type only the Hugging Face URL slug. For example, meta-llama.", no?

@ConorOM1 ConorOM1 Sep 17, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes correct ! added
image

Comment thread clients/ui/frontend/src/app/pages/modelCatalogSettings/constants.tsx
VALIDATION_FAILED: 'Validation failed',
VALIDATION_FAILED_BODY:
'Could not validate your organization or access token. Check your entries and try again.',
'The access token is invalid. Ensure that it is accurate, then try again.',

@ppadti ppadti Sep 17, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see the approved content for this - could you please check the doc again?

@ConorOM1 ConorOM1 Sep 17, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reconfirmed in doc

Comment thread clients/ui/frontend/src/app/pages/modelCatalogSettings/constants.tsx Outdated

@ppadti ppadti Sep 17, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be updated to "To preview models, validate the access token."
I still see this

Image

@ConorOM1 ConorOM1 Sep 17, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated
image

@ConorOM1
micro fixes
900fc68 
Signed-off-by: Conor O'Malley <conormomalley@gmail.com>
ppadti
ppadti approved these changes Sep 17, 2026
View reviewed changes

@ppadti ppadti left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ConorOM1
/lgtm
/approve

@google-oss-prow google-oss-prow Bot added the lgtm label Sep 17, 2026
@google-oss-prow

google-oss-prow Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ppadti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow
google-oss-prow Bot merged commit 0acae9c into kubeflow:main Sep 17, 2026
27 of 28 checks passed
@ppadti ppadti mentioned this pull request Sep 17, 2026
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chambridge chambridge Awaiting requested review from chambridge
@Philip-Carneiro Philip-Carneiro Awaiting requested review from Philip-Carneiro
1 more reviewer
@ppadti ppadti ppadti approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@ppadti ppadti

Labels

approved Area/UI lgtm ok-to-test size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ConorOM1 @ppadti