ci: Run unittests on commits to main and align checks for uncommited files - #216
christian-heusel wants to merge 2 commits into
Conversation
christian-heusel
commented
Feb 21, 2026
christian-heusel
commented
- ci: Enable the unit tests on the default branch
- ci: Check for uncommited files in profile-controller unit tests
|
/ok-to-test |
6df38cd to
5415045
Compare
5415045 to
8ea164f
Compare
|
This pull request has been automatically marked as stale because it has not had recent activity. Members may comment |
|
This pull request has been automatically closed because it has not had recent activity. |
|
/reopen |
|
@thesuperzapper: Reopened this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
This pull request has been automatically marked as stale because it has not had recent activity. Members may comment |
|
This pull request has been automatically closed because it has not had recent activity. |
|
/reopen |
|
@christian-heusel: Reopened this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Suggested-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com> Signed-off-by: Christian Heusel <christian@heusel.eu>
Suggested-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com> Signed-off-by: Christian Heusel <christian@heusel.eu>
8ea164f to
4369f63
Compare
There was a problem hiding this comment.
🟡 Changes recommended
The newly added profile-controller check duplicates the existing step exactly.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Enables unit-test workflows for pushes to main.
Changes:
- Adds
pushtriggers for both unit-test workflows. - Adds a duplicate profile-controller cleanliness check.
File summaries
| File | Description |
|---|---|
.github/workflows/profile_controller_unit_test.yaml |
Adds main push trigger and duplicate check. |
.github/workflows/poddefaults_unit_test.yaml |
Adds main push trigger. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
|
||
| - name: Check if there are uncommitted file changes | ||
| working-directory: components/profile-controller | ||
| run: | | ||
| clean=$(git status --porcelain) | ||
| if [[ -z "$clean" ]]; then | ||
| echo "Empty git status --porcelain: $clean" | ||
| else | ||
| echo "Uncommitted file changes detected: $clean" | ||
| git diff | ||
| exit 1 | ||
| fi |
