Repository navigation
netlify: move inline comments to separate lines in redirects - #891
Open
atul-upadhyay-7 wants to merge 1 commit into
Open
atul-upadhyay-7 wants to merge 1 commit into
atul-upadhyay-7 wants to merge 1 commit into
Conversation
Inline comments appended to redirect key-value lines in netlify.toml caused Netlify's redirect parser to trip up, which showed up as failing Redirect rules checks on merged PRs. Move the comments to their own lines above the keys. Signed-off-by: Atul Upadhyay <157039069+atul-upadhyay-7@users.noreply.github.com>
Collaborator
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
kubeedge-bot
added
the
size/XS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inline comments appended to the redirect key-value lines in
netlify.tomltripped up Netlify's redirect parser, which showed up as failingRedirect ruleschecks on merged PRs.Moved the comments to their own lines above the keys. This PR only touches
netlify.toml(4 additions, 2 deletions).Fixes #815
Replaces #834, which GitHub closed automatically after a branch rewrite. The FAQ changes that were mixed into that branch stay in #824.
Review requested from @Shelley-BaoYue and @fujitatomoya. Thanks!
Signed-off-by: Atul Upadhyay 157039069+atul-upadhyay-7@users.noreply.github.com