fix: make Recent News links keyboard accessible - #833
RedZapdos123 wants to merge 3 commits into
Conversation
Signed-off-by: Mridankan Mandal <xerontitan90@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Code Review
This pull request refactors the BlogPost component to use Docusaurus's Link component instead of programmatic navigation via useHistory, improving accessibility and SEO. It also replaces array indices with unique permalinks as React keys and updates the styling to support proper focus outlines. The feedback suggests adding display: inline-block to the post link class to ensure a clean, unfragmented focus outline for multi-line titles.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Signed-off-by: Mridankan Mandal <xerontitan90@gmail.com>
Which issue(s) this PR fixes:
Fixes #832
Bug fix
The homepage
Recent Newssection uses mouse-only navigation for its main actions.View Allis rendered as an anchor withonClickbut nohref, and each blog post title is rendered as a clickable<h3>, so keyboard users cannot tab to or open the post titles.View Allnow uses a semantic DocusaurusLink, and each homepage blog post title now renders as a semantic link to the post. Both controls are keyboard focusable and can be activated from the keyboard, with visible focus styling preserved on the homepage.No.
Verified with
corepack yarn buildand real homepage keyboard navigation:View AllTablands on the first blog post title linkEnteron the focused title link opens the blog post pageblogpost-after.mp4