Add support for multiple datasources in createExperiment and generate Recommendations.#1946
Draft
khansaad wants to merge 16 commits into
Draft
Add support for multiple datasources in createExperiment and generate Recommendations.#1946khansaad wants to merge 16 commits into
khansaad wants to merge 16 commits into
Conversation
Signed-off-by: bharathappali <abharath@redhat.com>
Signed-off-by: bharathappali <abharath@redhat.com>
Signed-off-by: bharathappali <abharath@redhat.com>
Signed-off-by: bharathappali <abharath@redhat.com>
Contributor
Reviewer's GuideAdds multi-datasource support for experiments and layer detection by introducing datasources lists on API/domain objects, updating layer detection to iterate and aggregate across all configured datasources, and adding focused unit tests for backward compatibility and aggregation behavior. Sequence diagram for multi-datasource layer detectionsequenceDiagram
participant CreateExperimentAPIObject as CreateExperimentAPIObject
participant ServiceHelpers as ServiceHelpers
participant KubernetesAPIObject as KubernetesAPIObject
participant ContainerAPIObject as ContainerAPIObject
participant LayerUtils as LayerUtils
ServiceHelpers->>CreateExperimentAPIObject: getDatasources()
ServiceHelpers->>CreateExperimentAPIObject: getKubernetesObjects()
loop for each KubernetesAPIObject
ServiceHelpers->>KubernetesAPIObject: getContainerAPIObjects()
loop for each ContainerAPIObject
ServiceHelpers->>ContainerAPIObject: getContainer_name()
loop for each datasourceName in datasources
ServiceHelpers->>LayerUtils: detectLayers(container_name, namespace, datasourceName)
LayerUtils-->>ServiceHelpers: Map<String, KruizeLayer>
ServiceHelpers->>ServiceHelpers: merge into aggregatedLayers
end
ServiceHelpers->>ContainerAPIObject: setLayerMap(aggregatedLayers)
end
end
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Signed-off-by: bharathappali <abharath@redhat.com>
Signed-off-by: Saad Khan <saakhan@ibm.com>
Signed-off-by: Saad Khan <saakhan@ibm.com>
251c3cc to
f76fc43
Compare
Signed-off-by: Saad Khan <saakhan@ibm.com>
Signed-off-by: Saad Khan <saakhan@ibm.com>
Signed-off-by: Saad Khan <saakhan@ibm.com>
Signed-off-by: Saad Khan <saakhan@ibm.com>
Signed-off-by: Saad Khan <saakhan@ibm.com>
Signed-off-by: Saad Khan <saakhan@ibm.com>
Signed-off-by: Saad Khan <saakhan@ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds support for multiple datasources in createExperiment and generate Recommendations.
Fixes # (issue)
Type of change
How has this been tested?
Please describe the tests that were run to verify your changes and steps to reproduce. Please specify any test configuration required.
Test Configuration
Checklist 🎯
Additional information
Include any additional information such as links, test results, screenshots here
Summary by Sourcery
Add multi-datasource support to experiments and layer detection while maintaining backward compatibility with the existing single datasource field.
New Features:
Enhancements:
Tests: