Repository navigation
Update README - #486
Merged
Merged
Update README#486
Conversation
dalg24
reviewed
Oct 15, 2026
dalg24
reviewed
Oct 15, 2026
dalg24
reviewed
Oct 15, 2026
dalg24
reviewed
Oct 15, 2026
dalg24
reviewed
Oct 15, 2026
crtrott
force-pushed
the
update-readme
branch
2 times, most recently
from
October 15, 2026 21:57
2095bbb to
f7dde61
Compare
mhoemmen
requested changes
Oct 15, 2026
mhoemmen
left a comment
mhoemmen
left a comment
Contributor
There was a problem hiding this comment.
Thanks Christian! Some comments.
| - the conditional explicit markup is missing, making certain constructors implicit | ||
| - most notably you can implicitly convert from dynamic extent to static extent, which you can't in C++20 mode | ||
| - there is a constraint on `layout_left::mapping::stride()`, `layout_right::mapping::stride()` and `layout_stride::mapping::stride()` that `extents_type::rank() > 0` is `true`, which is not implemented in C++17 or C++14. | ||
| - `submdspan` is not available. |
Contributor
There was a problem hiding this comment.
This seems to contradict what I see under C++14.
Signed-off-by: Christian Trott <crtrott@sandia.gov>
crtrott
force-pushed
the
update-readme
branch
from
October 15, 2026 22:48
f7dde61 to
0ef009d
Compare
crtrott
commented
Oct 15, 2026
Member
Author
There was a problem hiding this comment.
Suggested change
| - you can control which operator is available by defining `MDSPAN_USE_BRACKET_OPERATOR=[0,1]` and `MDSPAN_USE_PAREN_OPERATOR=[0,1]` irrespective of whether language support for multidimensional `operator[]` is detected. |
Co-authored-by: Mark Hoemmen <mhoemmen@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.