Skip to content

fix: pin series/book picker actions above the scrolling grid #262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
everpcpc merged 1 commit into from
Oct 20, 2026
Merged

fix: pin series/book picker actions above the scrolling grid #262

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 29 additions & 29 deletions webui/src/components/collections/SeriesPickerDialog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,8 +85,8 @@ export function SeriesPickerDialog({
}

return (
<Dialog open={open} onOpenChange={onOpenChange} title={title} size="lg">
<div className="px-5 pt-4">
<Dialog open={open} onOpenChange={onOpenChange} title={title} size="lg" fill>
<div className="shrink-0 px-5 pt-4">
<div className="relative">
<MagnifyingGlass className="pointer-events-none absolute top-1/2 left-3 size-4 -translate-y-1/2 text-ink-3" />
<input
Expand All @@ -99,7 +99,33 @@ export function SeriesPickerDialog({
/>
</div>
</div>
<div className="min-h-72 px-5 py-4">
<div className="flex shrink-0 items-center justify-between gap-2 px-5 py-3.5">
<p className="text-sm text-ink-3">
{error ? (
<span className="text-danger">{error}</span>
) : selected.size > 0 ? (
t('collection.selectedSeriesCount', { count: selected.size })
) : mode === 'single' ? (
t('picker.pickOneSeries')
) : (
t('picker.noneSelected')
)}
</p>
<div className="flex gap-2">
<Button variant="ghost" onClick={() => onOpenChange(false)}>
{t('common:action.cancel')}
</Button>
<Button
variant="primary"
loading={confirming}
disabled={selected.size === 0 || (mode === 'single' && selected.size !== 1)}
onClick={() => onConfirm([...selected.values()])}
>
{confirmLabel}
</Button>
</div>
</div>
<div className="min-h-72 flex-1 overflow-y-auto border-t border-line px-5 py-4">
{q.isPending ? (
<div className="grid grid-cols-3 gap-4 sm:grid-cols-4">
{Array.from({ length: 8 }, (_, i) => (
Expand Down Expand Up @@ -170,32 +196,6 @@ export function SeriesPickerDialog({
</>
)}
</div>
<div className="flex items-center justify-between gap-2 border-t border-line px-5 py-3.5">
<p className="text-sm text-ink-3">
{error ? (
<span className="text-danger">{error}</span>
) : selected.size > 0 ? (
t('collection.selectedSeriesCount', { count: selected.size })
) : mode === 'single' ? (
t('picker.pickOneSeries')
) : (
t('picker.noneSelected')
)}
</p>
<div className="flex gap-2">
<Button variant="ghost" onClick={() => onOpenChange(false)}>
{t('common:action.cancel')}
</Button>
<Button
variant="primary"
loading={confirming}
disabled={selected.size === 0 || (mode === 'single' && selected.size !== 1)}
onClick={() => onConfirm([...selected.values()])}
>
{confirmLabel}
</Button>
</div>
</div>
</Dialog>
)
}
58 changes: 29 additions & 29 deletions webui/src/components/readlists/BookPickerDialog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,8 +85,8 @@ export function BookPickerDialog({
}

return (
<Dialog open={open} onOpenChange={onOpenChange} title={title} size="lg">
<div className="px-5 pt-4">
<Dialog open={open} onOpenChange={onOpenChange} title={title} size="lg" fill>
<div className="shrink-0 px-5 pt-4">
<div className="relative">
<MagnifyingGlass className="pointer-events-none absolute top-1/2 left-3 size-4 -translate-y-1/2 text-ink-3" />
<input
Expand All @@ -99,7 +99,33 @@ export function BookPickerDialog({
/>
</div>
</div>
<div className="min-h-72 px-5 py-4">
<div className="flex shrink-0 items-center justify-between gap-2 px-5 py-3.5">
<p className="text-sm text-ink-3">
{error ? (
<span className="text-danger">{error}</span>
) : selected.size > 0 ? (
t('selectedCount', { count: selected.size })
) : mode === 'single' ? (
t('picker.pickOne')
) : (
t('picker.noneSelected')
)}
</p>
<div className="flex gap-2">
<Button variant="ghost" onClick={() => onOpenChange(false)}>
{t('common:action.cancel')}
</Button>
<Button
variant="primary"
loading={confirming}
disabled={selected.size === 0 || (mode === 'single' && selected.size !== 1)}
onClick={() => onConfirm([...selected.values()])}
>
{confirmLabel}
</Button>
</div>
</div>
<div className="min-h-72 flex-1 overflow-y-auto border-t border-line px-5 py-4">
{q.isPending ? (
<div className="grid grid-cols-3 gap-4 sm:grid-cols-4">
{Array.from({ length: 8 }, (_, i) => (
Expand Down Expand Up @@ -173,32 +199,6 @@ export function BookPickerDialog({
</>
)}
</div>
<div className="flex items-center justify-between gap-2 border-t border-line px-5 py-3.5">
<p className="text-sm text-ink-3">
{error ? (
<span className="text-danger">{error}</span>
) : selected.size > 0 ? (
t('selectedCount', { count: selected.size })
) : mode === 'single' ? (
t('picker.pickOne')
) : (
t('picker.noneSelected')
)}
</p>
<div className="flex gap-2">
<Button variant="ghost" onClick={() => onOpenChange(false)}>
{t('common:action.cancel')}
</Button>
<Button
variant="primary"
loading={confirming}
disabled={selected.size === 0 || (mode === 'single' && selected.size !== 1)}
onClick={() => onConfirm([...selected.values()])}
>
{confirmLabel}
</Button>
</div>
</div>
</Dialog>
)
}
Loading