Testplan multi-clone - #4001
Merged
Merged
Testplan multi-clone#4001
Conversation
atodorov
marked this pull request as draft
May 26, 2025 19:23
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Contributor
|
Hi @atodorov, sorry I got distracted away from this issue. Is this still something you are intrested in adding into Kiwi. Is there anything I can do to help? |
Member
Author
Yes, although it's not an immediate priority.
Not for now. I'll let you know once I can get back to this. |
atodorov
force-pushed
the
testplan-multi-clone
branch
2 times, most recently
from
September 29, 2026 18:06
3e2c380 to
bee0131
Compare
atodorov
force-pushed
the
testplan-multi-clone
branch
2 times, most recently
from
September 30, 2026 09:44
81edcf6 to
cf68720
Compare
kiwitcms-bot
force-pushed
the
testplan-multi-clone
branch
4 times, most recently
from
September 30, 2026 10:04
850a887 to
ea1202f
Compare
atodorov
force-pushed
the
testplan-multi-clone
branch
from
September 30, 2026 10:07
ea1202f to
c609716
Compare
seems a bit more appropriate
The multi-clone URL is built from the checkbox DOM, never from the DataTables Select extension state, so table.row().select()/deselect() only maintained unused state. initComplete now only checks/unchecks the row checkboxes without firing a change event for them.
When selecting test plans for multi-clone do not automatically include the children of a parent row. Only explicitly checked rows are cloned. NOTE: 'Select all' only affects visible checkboxes Some rows are hidden (e.g. child rows of an expanded parent) so skip them when the header checkbox is toggled.
to prevent it from showing inside 'Column visibility' selection
make the button more square-ish which looks better with the rest of the buttons. The fa-code-fork icon is very narrow and doesn't look good. Also update button text to just the action -> "Clone"
atodorov
force-pushed
the
testplan-multi-clone
branch
from
September 30, 2026 10:30
63b2601 to
65cbe2d
Compare
kiwitcms-bot
force-pushed
the
testplan-multi-clone
branch
from
September 30, 2026 10:41
db49c74 to
2c2af3f
Compare
Render data-plan-id on each checkbox, sourced from data.id, and read it directly via jQuery .data() instead of digging the ID out of the third table cell.
kiwitcms-bot
force-pushed
the
testplan-multi-clone
branch
from
September 30, 2026 10:42
2c2af3f to
f40a6f1
Compare
Both columns inherited the default cell padding and grew as wide as the ID column, leaving a lot of empty space around the checkbox and the expand marker. Move the override into a standalone stylesheet and pin the columns to their content.
kiwitcms-bot
force-pushed
the
testplan-multi-clone
branch
from
September 30, 2026 11:21
a6c98e0 to
402a6cb
Compare
atodorov
marked this pull request as ready for review
September 30, 2026 11:28
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picks some of the initial work in #3985 and refactors it to better fit the existing code style and how we do things in Kiwi TCMS.