[MAINTENANCE] Extract document retrieval logic in ReindexCommand#1993
Open
beatrycze-volk wants to merge 2 commits into
Open
[MAINTENANCE] Extract document retrieval logic in ReindexCommand#1993beatrycze-volk wants to merge 2 commits into
beatrycze-volk wants to merge 2 commits into
Conversation
…eindexCommand` The `--use-cache` option allows the reindex command to retrieve document data from the cache if available, potentially speeding up reindexing by avoiding redundant data loading. Additionally, the cache clearing mechanism has been optimized. Instead of flushing the entire document cache for each reindexed item, only the specific document's cache entry is now removed. This prevents unnecessary invalidation of unrelated cache entries and improves performance during reindexing.
beatrycze-volk
added
the
⟳ maintenance
The `execute` method of the `ReindexCommand` contained duplicated logic for fetching documents based on different CLI options (all documents vs. by collections, with or without limit/offset). This change extracts this common logic into dedicated private methods (`getAllDocuments` and `getCollectionsDocuments`). This improves readability and maintainability by reducing code duplication and making the `execute` method more concise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #1991