feat(web): add abstraction for main correction-search algorithm, leveraged types 🚂#15817
Open
jahorton wants to merge 2 commits intorefactor/web/extract-duplicate-result-filterfrom
Open
Conversation
User Test ResultsTest specification and instructions User tests are not required Test Artifacts
|
This was referenced Apr 9, 2026
jahorton
commented
Apr 9, 2026
Comment on lines
+36
to
38
| export class TokenResultMapping implements CorrectionResultMapping<SearchNode> { | ||
| readonly matchingSpace: SearchQuotientNode; | ||
| readonly node: SearchNode; |
Contributor
Author
There was a problem hiding this comment.
Note that for correction-search processes, we need access to the following data for results:
- The object best representing the context-variation that led to the correction.
- For tokens, that's
SearchQuotientNode- each of which represents a given range of the context and possible edit sequences.
- For tokens, that's
- The corrections themselves.
- For tokens, that's
SearchNode, which represents the specific edits made and tracks the LexicalModel object that provides efficient correction + prediction lookup operations.
- For tokens, that's
30bb779 to
3ae0e4c
Compare
…raged types Build-bot: skip build:web Test-bot: skip
6cedadc to
eaf419f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finishing up the batch of work started in #15814, this PR enacts new type abstractions that will let us search for context corrections in new ways.
As mentioned in #15814...
A new implementation of the abstract interfaces introduced here will come in #15818. Those changes will support correction-search over multiple tokens at once, allowing word-boundary corrections while prioritizing which token to search at any given time in support of completing a full phrase (possibly multiple tokens).
Build-bot: skip build:web
Test-bot: skip