Skip to content

devices: qemu: add qemu-lava pass-through device#33

Merged
roxell merged 2 commits into
kernelci:mainfrom
bhcopeland:qemu-lava
Jun 12, 2026
Merged

devices: qemu: add qemu-lava pass-through device#33
roxell merged 2 commits into
kernelci:mainfrom
bhcopeland:qemu-lava

Conversation

@bhcopeland

Copy link
Copy Markdown
Member

Add a QemuLAVA device that accepts a raw LAVA job definition via --job-definition and returns it unchanged, mirroring the existing fvp-lava device.

Add unit tests covering device selection, the missing-argument error, and pass-through of a sample QEMU job definition.

@bhcopeland bhcopeland requested a review from roxell June 4, 2026 16:47
Comment thread tuxlava/devices/qemu.py Outdated
@bhcopeland bhcopeland force-pushed the qemu-lava branch 2 times, most recently from 553c8cd to 3445e96 Compare June 5, 2026 09:01
@roxell

roxell commented Jun 5, 2026

Copy link
Copy Markdown
Collaborator

I think commit kselftest: increase BPF timeout from 45 to 120 minutes was added here by mistake.

@bhcopeland

Copy link
Copy Markdown
Member Author

I think commit kselftest: increase BPF timeout from 45 to 120 minutes was added here by mistake.

Or I am checking you are reviewing properly =D. Removed thanks

Comment thread tuxlava/devices/lava.py
Comment thread tuxlava/devices/lava.py Outdated
@roxell

roxell commented Jun 10, 2026

Copy link
Copy Markdown
Collaborator

Can we please update the commit messages?

In commit "devices: add LAVADevice base..." you say something like, "and rebase fvp-lava onto it.", not sure its needed. maybe add "no functional changes"?

and in commit "devices: qemu: add qemu-lava..." should say: "devices: lava: add qemu-lava..."

Move the shared passthrough logic, load and validate a LAVA job
definition and return it unchanged, into a new LAVADevice base in
devices/lava.py.

No functional changes.

Signed-off-by: Ben Copeland <ben.copeland@linaro.org>
Add a qemu-lava device that submits a raw LAVA job definition
unchanged, built on the shared LAVADevice base.

Add unit tests for device selection, the missing-argument error, and
passthrough of a sample QEMU job definition.

Signed-off-by: Ben Copeland <ben.copeland@linaro.org>
@bhcopeland

Copy link
Copy Markdown
Member Author

Can we please update the commit messages?

In commit "devices: add LAVADevice base..." you say something like, "and rebase fvp-lava onto it.", not sure its needed. maybe add "no functional changes"?

and in commit "devices: qemu: add qemu-lava..." should say: "devices: lava: add qemu-lava..."

Done

@roxell roxell added this pull request to the merge queue Jun 12, 2026
Merged via the queue into kernelci:main with commit 09e6511 Jun 12, 2026
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants