Skip to content

Fix integration icons in production - #532

Merged
juecd merged 1 commit into
mainfrom
feature/fix-integration-icon-production-css
Sep 1, 2026
Merged

juecd merged 1 commit into
mainfrom
feature/fix-integration-icon-production-css

Conversation

@goosewin

@goosewin goosewin commented Sep 1, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • restore monochrome integration icons after the revert
  • match Mintlify CDN-rewritten asset URLs in navigation CSS
  • scope styling to #navigation-items and use semantic group ordering
  • add a local/CDN selector regression fixture

Mintlify rewrites local image paths to absolute CDN URLs with query strings in production. The previous prefix/suffix selectors only matched local preview URLs, so production lost all sizing, opacity, ordering, and dark-mode styles.

Verification

  • npx --yes mint@latest validate
  • xmllint --noout for all integration SVGs
  • local and CDN-shaped selector regression fixture
  • light/dark responsive checks at 320, 375, 768, 1024, 1440, and 1920 px

Notes

This PR does not use !important for integration icon styling.


Note

Low Risk
Documentation and presentation CSS only; no runtime API, auth, or data-handling changes.

Overview
Restores integration sidebar icons in production by wiring monochrome SVG assets into navigation and fixing CSS so it still applies after Mintlify rewrites image URLs to Mintlify CDN hosts with query strings.

Adds icon paths in docs.json for nested Integrations groups (Claude, Computer Use Models, Stripe Projects, Vercel) and icon frontmatter on individual integration MDX pages, backed by new assets under images/integration-icons/.

Updates style.css with #navigation-items-scoped rules that match icons via img[src*="/images/integration-icons/"] (works for both local and CDN src), including 14px sizing, opacity, dark-mode invert(1), flex order so icons sit correctly beside labels, and small per-logo scale/opacity tweaks.

Adds .github/tests/integration-icon-css.html as a browser regression check that local and CDN-shaped URLs get the same computed styles.

Reviewed by Cursor Bugbot for commit c528f9b. Bugbot is set up for automated code reviews on this repo. Configure here.

@mintlify

mintlify Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated (UTC)
Kernel 🟢 Ready View Preview Sep 1, 2026, 1:57 AM

💡 Tip: Enable Workflows to automatically generate PRs for you.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Risk assessment: Low

Approved. This is a scoped docs-site presentation change with no application logic, auth, data, or infrastructure impact.

What the diff actually changes

  • docs.json: adds icon paths on four existing Integrations groups (Claude, Computer Use Models, Stripe Projects, Vercel). Navigation structure is unchanged.
  • 8 integration MDX files: icon frontmatter only; page content is unchanged.
  • 12 SVGs under images/integration-icons/: path-only logos (<svg> / <path> / <title>). No <script>, event handlers, foreignObject, or external hrefs.
  • style.css: rules scoped to #navigation-items and img[src*="/images/integration-icons/"] for size, opacity, flex order, and dark-mode invert(1). No @import or url() fetches.
  • .github/tests/integration-icon-css.html: local computed-style fixture, not served as product code.

Why Low (not Very Low)

The CSS is user-facing (docs sidebar icons) and uses attribute-contains selectors plus :has() flex-order rules. That is more than a typo or copy-only edit, but the match surface is limited to integration-icon URLs and the sidebar container.

Why not Medium+

No shared services, auth/billing/permissions, APIs, schema, or infra. Blast radius is visual treatment of integration icons in the Mintlify sidebar.

No CODEOWNERS file is present, and the main ruleset does not require code-owner review. No prior approval on this PR.

Open in Web View Automation 

Sent by Cursor Automation: Assign PR reviewers

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Want higher recall? High effort reviews run extra passes and find more bugs. A team admin can switch effort levels in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit c528f9b. Configure here.

Comment thread docs.json
"integrations/valtown",
{
"group": "Vercel",
"icon": "/images/integration-icons/vercel.svg",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Custom integration sidebar icons reintroduced

Medium Severity

This change restores custom icon values on Integrations groups and pages, new assets under images/integration-icons/, and CSS that sizes, scales, reorders, and dark-mode-inverts those sidebar icons. Integration nav items stay text-only after those icons were reverted.

Additional Locations (2)
Fix in Cursor Fix in Web

Triggered by learned rule: Do not add custom icons to Integrations nav or pages

Reviewed by Cursor Bugbot for commit c528f9b. Configure here.

@juecd
juecd merged commit d0064bd into main Sep 1, 2026
4 checks passed
@juecd
juecd deleted the feature/fix-integration-icon-production-css branch September 1, 2026 14:18
@goosewin goosewin mentioned this pull request Sep 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants