Repository navigation
fix(string): compare full URL parameter names - #2774
Merged
keon merged 2 commits intoSep 25, 2026
Merged
Conversation
keon
approved these changes
Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
strip_url_params2used only the first character of each query parameter as its key. Different parameters with the same first letter were therefore treated as duplicates.For example:
Previously returned
https://x.test?ab=1, incorrectly droppingac. The expected result ishttps://x.test?ab=1&ac=2:abappears twice, butacis a separate parameter.The previous loop also skipped the first parameter when applying
param_to_strip.Changes
=for duplicate checks.param_to_stripto every parameter, including the first.Tests
Added regression cases for distinct names with a shared first letter, repeated multi-character names, and removal of the first parameter.
Ran
python3 -m unittest discover -s tests -p test_string.py— all 68 tests passed.Fixes #2773