fix: tolerate null source import checksums#381
Merged
mariusvniekerk merged 2 commits intoJun 15, 2026
Conversation
roborev: Combined Review (
|
The NULL checksum regression coverage needs to run against both SQLite and PostgreSQL. The test forced a legacy NULL row through the raw DB handle, which bypasses the store logger's automatic placeholder rebinding and left PostgreSQL with SQLite-style question-mark placeholders. Use the store dialect rebind helper for that direct SQL so the coverage exercises the intended nullable checksum behavior on both backends instead of failing before it reaches the scan path. Validation: go test -tags "fts5 sqlite_vec" ./internal/store -run TestStore_SourceImportItems -count=1; MSGVAULT_TEST_DB=postgres://msgvault_test:msgvault_test@localhost:55432/msgvault_test?sslmode=disable go test -tags "fts5 sqlite_vec" ./internal/store -run TestStore_SourceImportItems -count=1; make test; make testify-helper-check Generated with Codex Co-authored-by: Codex <noreply@openai.com>
roborev: Combined Review (
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
Some source_import_items rows can have NULL checksum values, which previously caused scan errors when imported source items were read back.
Impact
Nullable checksums no longer break source import lookup or imported checksum listing; non-NULL checksum behavior is unchanged.
Validation