Repository navigation
Clean up challenge material when a solve is cancelled - #17
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dns01SolverandTlsAlpn01Solvernow track what they have put in place with a guard. If thesolve_and_finalizefuture is dropped before completing (a caller-side timeout,select!, shutdown), the guard tears down the remaining TXT records or challenge certificates from a task spawned on the current Tokio runtime. Cleanup stays best-effort: the spawned task does not run if the runtime shuts down first.Breaking change: the provider and responder type parameters now require
'static, since the solvers hold them in anArcshared with the cleanup task. Thenewsignatures are otherwise unchanged.