refactor: simplify CronJob and CronTime constructor overloads for timeZone/utcOffset exclusivity#1065
Open
ravvdevv wants to merge 1 commit into
Open
Conversation
…eZone/utcOffset exclusivity Removes redundant constructor overloads that used null types to enforce timeZone/utcOffset exclusivity. The type system already handles this via the CronJobParams union type. The runtime check in the implementation constructor was dead code in one overload. Single signature with proper types is cleaner and the runtime check still works correctly for JS users. Fixes kelektiv#704
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes redundant constructor overloads in CronJob and CronTime that used null types to enforce timeZone/utcOffset exclusivity at the signature level.
Problem
The type system already enforces exclusivity via the CronJobParams union type. The two constructor overloads (one with utcOffset?: null, one with timeZone?: null) made the runtime check at the implementation level dead code in one branch.
Changes
Testing
Fixes #704