Fix stale workflow history in fleet observation - #46
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fleet observer can receive stale workflow history from GitHub's server-side
branch=mainfilter. On fleet run 36444799139 this made Curitiba appear to have a February daily run and a February weekly failure, even though current September runs exist onmain.This change:
branchquery parameter;head_branchfield;This intentionally does not change the current scheduler-lag policy (warning after 3h, stale/failing after 7h). Lima and Milan were genuinely beyond that SLA in the affected fleet run, while the merged basemap core revision had not yet had a scheduled node-sync opportunity because all September 28 sync jobs ran before PR #45 merged.