Repository navigation
Split bindings.rb into per-area files - #1022
Open
coipond-coder[bot] wants to merge 2 commits into
Open
coipond-coder[bot] wants to merge 2 commits into
coipond-coder[bot] wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Redmine: 47594
Mechanical split of
lib/rdkafka/bindings.rb(810 lines) intolib/rdkafka/bindings/*.rb. No behaviour or API change.Rdkafka::Bindingsmodule (no submodules).ffi_lib, typedefs and callback constants stay on one module, soRdkafka::Bindings.rd_kafka_*and the karafka/karafka-core patches (remove_const/const_seton callbacks, externalattach_function) keep working.bindings.rbkeepsffi_lib+ glibc error, shared constants,SizePtr,rd_kafka_global_init, thenrequire_relatives:structs(allFFI::Structs, loaded first),polling,metadata,messages,configs,list_offsets,errors,configuration,callbacks,handle,consumer,producer,admin,acl.require_relatives, and 2 comments (# Stats→# Watermark offsets, new# Messages, topics and topic partition listsheader). Moves across sections: the structs intostructs.rb,rd_kafka_query_watermark_offsetsintolist_offsets.rb,rd_kafka_group_result_*intoadmin.rb.b4ca546(same machine): 275 singleton methods (names + arities), 117 constants (struct layouts and sizes included), 8 typedefs, 2 enums: identical.spec/lib/rdkafka/bindings_parity_spec.rbpins those 275 methods / 117 constants (additions need no spec change) and checks the 5 callback constants are own constants..rubocop.yml/.yard-lint.yml: thebindings.rbexclusions also coverlib/rdkafka/bindings/**/*.Overlap: #1019 adds 3
rd_kafka_message_*bindings andRD_KAFKA_MSG_STATUS_*afterrd_kafka_message_timestamp. Whichever merges second moves them intolib/rdkafka/bindings/messages.rb.