Repository navigation
docs(proposal): align the data-plane error-handling proposal with the implementation - #264
Open
rambohe-ch wants to merge 1 commit into
Open
rambohe-ch wants to merge 1 commit into
rambohe-ch wants to merge 1 commit into
Conversation
… implementation - Render the cluster-filter outage codes from the per-namespace consolidated local_reply in charts/modelharness; drop the cluster-wide local_reply in charts/productionstack and the duplicate bbr_unavailable row, and move the fail-closed filter requirements to modelharness. - Remove mesh_config_invalid, whose MeshConfig wiring no longer exists. - Narrow invalid_request_body to a JSON body without a model field and document BBR's native 400 for a non-JSON body as a passed-through exception, with the reason for not rewriting it. - Describe HA as implemented: readiness probes drive the EDS endpoint set, BBR adds passive outlier detection, and ext_authz relies on replicas and readiness with an accepted 502 window. - Point the Test Plan at the real *_spec.go files with a coverage status column, cover gateway_unavailable through the status reporter, and drop the ext_authz single-replica and upstream-timeout rows. - Fix the Story 4/5 examples and move the status to implementable. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: rambohe-ch <rambohe.ch@gmail.com>
rambohe-ch
requested review from
Fei-Guo,
techworldhello and
zhuangqh
as code owners
November 2, 2026 23:58
1 task done
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for Change:
The data-plane error-handling proposal has drifted from what
charts/modelharness,charts/productionstackand the E2E suite implement. This PR updates the proposal to match the implementation; no code changes. The control-plane proposal already matches the reporter and is unchanged.Why the proposal changes rather than the code:
local_reply: each inference Gateway has its own HTTP connection manager, and theMeshConfig-based cluster-wide wiring was removed because the AKS Istio add-on does not allow modifying the sharedMeshConfig. A second filter on the same HCM would also bring back the non-deterministicEnvoyFiltermerge order.local_replymatch for this case (a local400without the model header) also catches the missing-modeldirect_responseand Envoy's protocol-level400s, misattributing the latter tobbr. OpenAI SDK clients never send a non-JSON body.health_checks: the BBR and ext_authz clusters are generated by Istio, and BBR serves gRPC health only on a dedicated port. Readiness probes reach the same result through EDS.Remaining gaps are kept explicit: the
llm-gateway-auth401/403 envelope stays a cross-repo TBD, and the Test Plan marks the scenarios not covered yet. Status moves fromprovisionaltoimplementable.Requirements
Issue Fixed: