Skip to content

fix(eslint-config): kitql-lint -d base and long file lists - #1362

Merged
jycouet merged 3 commits into
mainfrom
fix/kitql-lint-diff-windows
Oct 30, 2026
Merged

jycouet merged 3 commits into
mainfrom
fix/kitql-lint-diff-windows

Conversation

@jycouet

@jycouet jycouet commented Oct 30, 2026 •

Copy link
Copy Markdown
Owner

kitql-lint -d crashed on Windows (spawn ENAMETOOLONG) when a stale local main inflated the diff.

  • Base: default compares to the merge-base with origin/main, then local main. Never fetches. Explicit -b keeps its ref, also via merge-base. No merge-base (shallow): direct diff, as before.
  • File lists are chunked (6000 chars on Windows, cmd.exe stops at 8191). Every chunk runs, any failure fails the run. In -d, oxlint gets --no-error-on-unmatched-pattern, else a chunk of only .png exits 1.
  • Quoting: paths already reached the tools safely through cmd.exe since 0.10.1. git now runs without a shell.

Verified on Windows with real eslint, oxfmt, oxlint on (group)/[handle=handle] paths and 900 paths.

Also fixed in -d: non-ASCII paths were silently skipped (git escapes them, now -z), and an 8.3 short cwd dropped every file (now realpath).

@pkg-pr-new

pkg-pr-new Bot commented Oct 30, 2026 •

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@kitql/eslint-config@1362

commit: 1d02e9c

@jycouet
jycouet merged commit aee0ce1 into main Oct 30, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant