Repository navigation
Clarify audio listener capture setup - #217
Merged
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: d960676f-2408-4b0c-a5a8-48744555a4e7
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the documentation for the audio listener pipeline to clarify that listeners consume PCM data produced by a started AudioStreamer (via OnAudioCaptured), not by AudioRecorder, and calls out an Android limitation when attempting to capture microphone audio concurrently.
Changes:
- Adds an IMPORTANT note explaining that audio listeners require PCM from
AudioStreamerand needStartAsync()to begin supplying samples. - Documents that running
AudioRecorderandAudioStreamerconcurrently (especially on Android) can result in one capture session receiving no samples. - Updates the basic example to show creating an
AudioStreamerand starting it.
Show a summary per file
| File | Description |
|---|---|
| docs/audio-listeners.md | Clarifies listener data source (AudioStreamer PCM) and documents Android concurrent microphone capture limitation; updates sample to start streaming. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clarifies that audio listeners receive PCM data from a started
AudioStreamer, not fromAudioRecorder, and documents the Android microphone capture limitation.Closes #215