Repository navigation
feat(history): comparable runs and trustworthy regression alerts - #24
Merged
Merged
Conversation
Version RunRecord with provenance, coverage, configuration, workload fingerprint, and distinct wall-clock/cumulative timing and memory/disk spill measures. Missing measures stay null. Make history storage selection deterministic so a .jsonl path stays JSONL after installing deltalake, and read legacy records as version 1 rather than treating historical zeros as measured values. Select baseline cohorts by workload identity, coverage, and optional runtime/compute dimensions with a configurable minimum sample count. Evaluate every alert rule into a status-bearing assessment, validate metric/window/threshold inputs, and forward alert output paths from the capture API. Add plan fingerprinting and a compare_runs report exposed through a new `sparkparse compare` command.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements brief 06 — comparable history and trustworthy regression alerts, in three increments.
Increment 1 — versioned records & deterministic storage
RunRecordv2 (RUN_RECORD_VERSION): provenance (status,backend,transport,compute_type,access_mode,runtime_version,client_version),workload_fingerprint,coverage,config; nullable measures; separateshuffle_read_bytes/shuffle_write_bytesandmemory_bytes_spilled/disk_bytes_spilled;cumulative_time_skept distinct from wall-clockduration_s.record_version=1with unknown provenance and are excluded from baselines; historical zeros are never reinterpreted as measured..jsonlstays JSONL, existing Delta stays Delta;autoonly uses the package heuristic for new stores.Increment 2 — baseline selection and rule assessments
select_baseline_cohortrequires the same workload identity (fingerprint, configurable), comparable coverage, and supports runtime/compute dimensions; filters null measurements before applying the window.check_alertsreturns a status-bearingAlertAssessmentper rule (triggered/clean/insufficient_data/unsupported/skipped), with configurablemin_samples, explicit true-zero handling, and finite-threshold/positive-window validation.alert_output_pathforon_trigger="file"and exposesalert_assessments.Increment 3 — comparison report
workload_fingerprint(stable across node ids, changes with join type/scan path).compare_runs+sparkparse compareCLI: compatible metrics, cohort/sample counts, excluded measures with reasons, andplan_changed.Validation
just ci— ruff, ruff format, pyrefly (0 errors), 477 passed / 2 skipped.