Repository navigation
Safe capture lifecycle and capability contract - #19
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements
plans/improvements-2026-09/01-capture-and-capabilities.md.own_session=Trueopts into a session sparkparse owns and shuts down before parsingCaptureResultcarriesdag,combined, metadata, capabilities, and diagnostics; unavailable Connect task/stage telemetry is reported as unavailable rather than as zeroes, and analysis/history keep those totals nullcap.result,cap.dfs,cap.analysis,cap.last_record,cap.triggered_alerts;_parsed_logsis gone with no legacy aliasbackend="classic" | "connect" | "event_log", the last for post-run ingestion with no session; borrowed captures select the log by application IDcapture_errors="record"keeps diagnostics and a partial result; user workload exceptions always take precedence, and failed captures retain their temp logsaction="viz"returns an in-memory HTML report incap.reporton either backend instead of launching a server; capture-result JSON uses Arrow IPC so schemas, empty tables, and nested metrics survive a round triptests/test_capture_contract.py(new, 290 lines), plus history and capture additionsSmoke-tested on Databricks Free serverless (run
566565689796128, 2026-09-12) alongside the local suite. That run was Connect-only — classic shutdown and log-flushing behavior is covered locally. A timezone inference failure in history reads under newer Polars surfaced there and is fixed with explicit UTC parsing and an offset-normalization regression test.