Repository navigation
minecraft-proxy: add optional labels and annotations on PVC - #291
Merged
Merged
Conversation
itzg
requested changes
May 12, 2026
itzg
left a comment
itzg
left a comment
Owner
There was a problem hiding this comment.
Changes look great. Bump the minor version of the chart and it's good to merge.
itzg
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First, thank you for all your work on the containerization of Minecraft.
Here is a small contribution for adding custom labels and annotations to the datadir PVC of the proxy.
Tell me if I can do anything,
Regards,
Maxi_Mega