add extra callback for main marker change - #72
Open
demon36 wants to merge 3 commits into
Open
Conversation
|
Kilo Code Review could not run — your account is out of credits. Add credits or switch to a free model to enable reviews on this change. |
itsarvinddev
added a commit
that referenced
this pull request
Sep 9, 2026
…uild The first CI run failed four ways. Three were real; all three were things the workflow existed to catch. 1. `channel: 3.38.0` — subosito/flutter-action's `channel` input only accepts stable/beta/master, so pinning the floor failed with "Unable to determine Flutter version for channel: 3.38.0". An exact release goes in `flutter-version`. The matrix is now an explicit `include` with an `id`, both because it reads better in the checks list and because `matrix.flutter-version` would have been parsed as subtraction in an Actions expression. 2. pana scored 150/160 on CI against 160/160 locally, losing the whole "example and screenshots" section to twelve "No such file or directory" errors. The screenshots are committed and are not LFS pointers -- pana shells out to ImageMagick and cwebp to generate thumbnails, and neither is on the ubuntu runner. Installed in that job. 3. The example's Android build failed on "You are applying Flutter's app_plugin_loader Gradle plugin imperatively using the apply script method, which is not possible anymore." The scaffold dated from 2022: Gradle 7.4, AGP 7.1.2, Kotlin 1.6.10, Groovy DSL, imperative plugin loader. Regenerated from the current Flutter template -- Kotlin DSL, declarative `plugins` block, Gradle 9.3.1, Java 17 -- keeping the API key meta-data and location permissions. Also dropped the legacy `package=` attribute from all three manifests (the namespace now lives in build.gradle.kts) and adopted the PROCESS_TEXT `queries` block the current template ships. `flutter build apk --debug` now succeeds locally. The fourth failure is the third-party Kilo Code Review bot, which also reports failure on the pre-existing #71 and #72. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.