Repository navigation
refactor(iota): consume iota-sdk-ledger and delete the Ledger crates - #13388
Draft
DaughterOfMars wants to merge 3 commits into
Draft
DaughterOfMars wants to merge 3 commits into
DaughterOfMars wants to merge 3 commits into
Conversation
Sign with the SDK's LedgerSigner in `iota client` and `iota keytool`, and delete crates/iota-ledger and crates/iota-ledger-signer. The SDK crates are pinned to the iota-rust-sdk commit that ships iota-sdk-ledger. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
muXxer
approved these changes
Oct 30, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
feat/ledger-crate, with feat: sign with a Ledger through the transaction builder iota-rust-sdk#1705 merged), which shipsiota-sdk-ledgerand theledgerfeature ofiota-sdk-transaction-builder.LedgerSigneriniota clientandiota keytool, and deletecrates/iota-ledgerandcrates/iota-ledger-signer.TransactionSigner::sign_with_objects, which blind-signs with a warning on IOTA apps older than 1.0.LEDGER_SIMULATORstill connects to Speculos at127.0.0.1:9999.docs/examples/rust/Cargo.lockalso picks up unrelated changes from thecargo fetchthat./scripts/update_rust_sdk.shruns.Draft until iotaledger/iota-rust-sdk#1702 merges into
develop; the SDK pin then moves to its commit there. Untiliota-sdk-ledgeris on crates.io,./scripts/update_rust_sdk.shwithout a commit fails.Links to any relevant issues
Fixes #13134. Part of iotaledger/iota-rust-sdk#1675.
How the change has been tested
Basic tests (linting, compilation, formatting, unit/integration tests)
Patch-specific tests (correctness, functionality coverage)
I have added tests that prove my fix is effective or that my feature works
I have checked that new and existing unit tests pass locally with my changes
New unit test: an object rebuilt from its JSON-RPC response keeps its digest.
The CLI signing sim tests pass (
test_signature_flag,test_execute_signed_tx,test_move_authenticator*).Not yet run against a Ledger device or Speculos.
Release Notes
🤖 Generated with Claude Code