Replace gp2 with gp3 - #1606
Conversation
|
|
a174e43 to
9a93388
Compare
the-glu
left a comment
the-glu
left a comment
There was a problem hiding this comment.
gp2/gp3 changes looks good, I'm not sure about script generation changes and the diff. Maybe consider a separate PR to split concerns?
| INTERNAL_VARIABLES_FILENAME = "variables_internal.tf" | ||
| GENERATED_COMMENT = """ | ||
| # This file has been automatically generated by /deploy/infrastructure/utils/generate_terraform_variables.py. | ||
| # This file has been automatically generated by /deploy/infrastructure/utils/variables.py. |
There was a problem hiding this comment.
Why the change? Isen't generate_terraform_variables the script to ran?
There was a problem hiding this comment.
There doesn't seem to be a generate_terraform_variables.py. As in an explicit python script
There was a problem hiding this comment.
What I mean is, I ran the variables.py script, which is what the generate_terraform_variables bash script runs, right?
There was a problem hiding this comment.
So what I always do is run ./generate_terraform_variables.sh in the folder, who run variables.py.
This will run it with explicit version of the package needed with the docker image.
There was a problem hiding this comment.
I appreciate the explanation. I misunderstood the comment in the py file. I should have read the official documentation :)
There was a problem hiding this comment.
No worries. I checked since it probably mean latest version of the library introduced some change and created #1609 to upgrade it.
|
|
||
| declared_var_name = list(variables[0].keys())[0] | ||
| if declared_var_name != variable_name: | ||
| if declared_var_name.strip('"') != variable_name: |
There was a problem hiding this comment.
Is this really correct? The same should be the same including spaces no?
There was a problem hiding this comment.
So, when I ran it, I got an error that showed declared_var_name with quotes. Would it be possible for you to check?
There was a problem hiding this comment.
When running generation on your branch with ./generate_terraform_variables.sh, it does seems to be working for me.
There was a problem hiding this comment.
Thank you for taking the time to verify. TIL how to generate the files correctly.
wing-utm-sharing-airspace
changed the title
gp2 with gp3 and minor script modificationgp2 with gp3
2 participants
gp2currently is slower and more expensive.