[raft/memstore] Use now from context - #1535
Merged
mickmis merged 1 commit intoJul 30, 2026
Merged
Conversation
barroco
added
the
dss-raft
This was referenced Jun 18, 2026
the-glu
force-pushed
the
memstore_use_time_from_context
branch
from
June 18, 2026 08:29
6b7c7a4 to
3ca9a8a
Compare
This was referenced Jun 18, 2026
the-glu
force-pushed
the
memstore_use_time_from_context
branch
from
June 19, 2026 13:27
3ca9a8a to
b55295d
Compare
This was referenced Jun 19, 2026
the-glu
force-pushed
the
memstore_use_time_from_context
branch
2 times, most recently
from
June 29, 2026 07:04
6622fd6 to
d5e48e1
Compare
the-glu
force-pushed
the
memstore_use_time_from_context
branch
4 times, most recently
from
July 1, 2026 09:20
2b6994d to
0269e18
Compare
the-glu
force-pushed
the
memstore_use_time_from_context
branch
from
July 13, 2026 08:58
0269e18 to
65c0949
Compare
mickmis
approved these changes
Jul 28, 2026
mickmis
left a comment
mickmis
left a comment
Contributor
There was a problem hiding this comment.
- if available, add linter guarding against use of
time.Now(), at least in those directories as a start?
Otherwise LGTM modulo comments about UTC.
the-glu
force-pushed
the
memstore_use_time_from_context
branch
2 times, most recently
from
July 30, 2026 13:17
b58e623 to
f5b49d4
Compare
mickmis
approved these changes
Jul 30, 2026
mickmis
left a comment
mickmis
left a comment
Contributor
There was a problem hiding this comment.
LGTM
I have a suggestion, LMK what you think of it and if you agree whether you would do it in this PR or a follow-up one.
the-glu
force-pushed
the
memstore_use_time_from_context
branch
from
July 30, 2026 14:14
f5b49d4 to
0301ea5
Compare
the-glu
force-pushed
the
memstore_use_time_from_context
branch
from
July 30, 2026 14:17
0301ea5 to
2307844
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is part of a new chain, implementing memstore.
#1525 (Generic raftstore) -> #1527 (Base memstore) -> #1529 (Aux memstore) -> #1530 (Snapshots) -> #1534 (Rid memstore) -> #1535 (Correct use of now) -> #1539 (Checkpoint) -> #1542 (Scd memstore) -> #1528 (First PR with raft using memstore)
It uses the helper from timestamp to use now from context, if available, to ensure consistent time in the raft context.