feat:(PB-6297) preview public shared folder contents - #2052
Merged
Conversation
This was referenced Jul 17, 2026
…terators New-code coverage was failing the SonarCloud quality gate (75% vs 80% required). Adds tests for the untested useWarnBeforeUnload hook and for the previously uncovered lines in share.service.ts: the folders/files iterator factories passed to downloadFolderAsZip, and the happy/error paths of downloadPublicSharedFolder.
CandelR
requested changes
Jul 24, 2026
CandelR
left a comment
CandelR
left a comment
Collaborator
There was a problem hiding this comment.
Check sonnar and the layout whilst navigate, there are some odd jumps when the content stops loading
Deploying drive-web with
|
| Latest commit: |
91bed92
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://27984dc7.drive-web.pages.dev |
| Branch Preview URL: | https://pb-6297-folder-link-preview.drive-web.pages.dev |
# Conflicts: # src/views/PublicShared/hooks/usePublicSharedFolderContent.ts
CandelR
reviewed
Jul 28, 2026
CandelR
left a comment
CandelR
left a comment
Collaborator
There was a problem hiding this comment.
The flickering persists when the loaded list is empty. There are also subfolders where, when navigating, the server returns a 500 error and it just keeps loading instead of displaying any kind of error message. I’ve attached a video, if you have any further questions, we can discuss them via DM
Screen.Recording.2026-07-28.at.10.56.05.mov
# Conflicts: # src/views/PublicShared/components/PublicSharedFolderContent.tsx
# Conflicts: # src/views/PublicShared/components/PublicSharedFolderContent.tsx # src/views/PublicShared/components/PublicSharedItemList.tsx # src/views/PublicShared/hooks/usePublicSharedFolderContent.ts
CandelR
previously approved these changes
Jul 29, 2026
Moves download and preview state out of PublicSharedFolderContent into usePublicSharedDownload, discarding stale preview downloads when the preview is closed or replaced, and removes 'as unknown as' casts by typing fileId on AdvancedSharedItem and narrowing helper signatures.
feat:(PB-6297) show image thumbnails in public shared folder preview
feat:(PB-6297) download and preview individual items in public shared folder
…-preview # Conflicts: # src/app/drive/services/thumbnail.service.test.ts # src/views/Checkout/views/CheckoutView.tsx
|
CandelR
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
First part of PB-6297 (public shared folder preview). Until now, a public folder link only showed a card with the folder name and a Download button — the recipient had to download the whole folder as a zip without knowing its contents.
This PR adds a "View" button next to Download that opens a read-only listing of the shared folder contents, fetched without authentication:
usePublicSharedFolderContent(new hook): fetches folders first and then files per level viagetPublicSharedFolderContent, handling pagination (30 items/page), per-level resource tokens (each response provides the token that authorizes listing the next level) and network credentials (returned by the files request, which carries the linkcode).PublicSharedFolderContent(new): breadcrumbs, item selection, sorting, and navigation into subfolders. Exiting the preview returns to the classic card.PublicSharedItemList(new): list UI for the items.ShareFolderView: renders the new preview when the eye button is clicked.ShareFileView: Phosphor icon imports renamed to their non-deprecated*Iconvariants (no behavior change).Scope note: this PR only lists contents. Image thumbnails and per-item download/preview come in two follow-up stacked PRs.
Related Issues
Relates to PB-6297.
Related Pull Requests
Stacked on top of this PR (will be opened next):
PB-6297-thumbnails— image thumbnails in the listing.PB-6297-preview-download— per-item download and file preview.Checklist
Testing Process
yarn vitest run src/views/PublicShared/hooks/usePublicSharedFolderContent.test.ts(4 tests: initial folders→files fetch sequence, subfolder navigation with the parent level token + breadcrumb back-navigation, no-op navigation guards, and pagination).yarn typecheckandyarn lintclean; full unit suite run by the pre-commit hook./sh/folder/:token/:code), clicked View, browsed root and subfolders, checked pagination on folders with 30+ items, breadcrumb navigation back to parent levels, and exit back to the download card. Verified with and without link password.Additional Notes