[_] feature/Added Photos thumbnail cache invalidation and refresh - #566
Merged
Conversation
CandelR
force-pushed
the
feature/refresh-Photos-thumbnails
branch
from
August 6, 2026 14:36
961ab7b to
eb7b959
Compare
larryrider
approved these changes
Aug 6, 2026
CandelR
force-pushed
the
feature/refresh-Photos-thumbnails
branch
from
August 7, 2026 11:41
9e59fdd to
b85c7cb
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added thumbnail cache invalidation and refresh for local and cloud assets
Summary
PhotosScreen/types.ts,photoTimelineGroups.ts: addedmodificationTimetoPhotoItem, sourced from the sameMediaLibrary.Assetfield the sync layer already uses to detect edits.PhotoItem.tsx: the grid'sExpoImagenow keys its cache on${id}-${modificationTime}instead of just the URI (which iOS doesn't change on edit).PhotoCloudBrowser.ts: picks the most recently created thumbnail instead of blindly usingthumbnails[0], and evicts the orphaned cached thumbnail file from disk when a file's thumbnail bucket changed.cloud_asset.ts: the cloud asset upsert now nulls the cachedthumbnail_pathwhenthumbnail_bucket_filechanged, so stale local caches get invalidated instead of persisted forever.database/photosLocalDB.ts: newgetCachedThumbnailRefsbatch lookup, plus a sharedbuildInClausePlaceholdershelper reused across the existing chunked queries.