Skip to content

add attributes to report dynamic resolution support#636

Open
XinfengZhang wants to merge 1 commit intointel:masterfrom
XinfengZhang:drc
Open

add attributes to report dynamic resolution support#636
XinfengZhang wants to merge 1 commit intointel:masterfrom
XinfengZhang:drc

Conversation

@XinfengZhang
Copy link
Copy Markdown
Contributor

Signed-off-by: Carl Zhang carl.zhang@intel.com

Signed-off-by: Carl Zhang <carl.zhang@intel.com>
Comment thread va/va.h
VAConfigAttribEncPerBlockControl = 55,
/** \brief dynamic resolution change support. Read-only.
*
* This attributes describes whether backend driver support dynamic resolution change
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct the grammar: This attribute(-s) describes whether the backend driver supports(+s)...indicate whether needing to reset context.

Comment thread va/va.h
*
* 0: invalid value
* 1: need to reset context for drc
* 2: could not reset context for drc
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better to indicate "In this case, context resolution will not limit runtime surface resolution."

Comment thread va/va.h
* 1: need to reset context for drc
* 2: could not reset context for drc
*/
uint32_t drc_context_reset : 4;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 bits are enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants