add histogram output support for decode#207
add histogram output support for decode#207XinfengZhang wants to merge 1 commit intointel:masterfrom
Conversation
There was a problem hiding this comment.
for R, G, B, do we need to give distinct values for Y, U, V?
There was a problem hiding this comment.
this is for the caps reporting, we can t report 0x7 only, customer dont know whether we support RGB or YUV from value 0x7
XinfengZhang
force-pushed
the
histogram
branch
3 times, most recently
from
31a3c71 to
9cdacff
Compare
| * This attribute conveys the number of bins per channel if the | ||
| * driver supports histogram reporting. | ||
| */ | ||
| VAConfigAttribHistogramBinCount = 39, |
There was a problem hiding this comment.
How does a user know which channel is queried if the driver supports multiple channels? Do all channels have the same number of bins?
XinfengZhang
force-pushed
the
histogram
branch
from
9cdacff to
d43d80a
Compare
XinfengZhang
force-pushed
the
histogram
branch
from
d43d80a to
5d6675e
Compare
| uint32_t reserved : 8; | ||
| } bits; | ||
| uint32_t value; | ||
| } VAConfigAttribHistogramBin; |
There was a problem hiding this comment.
It would be better to keep the same name style, _VAConfigAttribHistogram and VAConfigAttribHistogram, or _VAConfigAttribHistogramBin and VAConfigAttribHistogramBin
| /** \brief bin count for given channel. */ | ||
| uint32_t bin_count : 16; | ||
| /** \brief driver support channel */ | ||
| uint32_t channel : 8; |
There was a problem hiding this comment.
does it support multiple channels?
There was a problem hiding this comment.
yes, for the caps report, will return several VAConfigAttribHistograms , also application can send multiple VAEncMiscParameterHistorgram
XinfengZhang
force-pushed
the
histogram
branch
2 times, most recently
from
86ab858 to
bc8cc31
Compare
Signed-off-by: XinfengZhang <carl.zhang@intel.com>
|
@xhaihao do you still have other concern? if no , I will merge it |
4 participants
Signed-off-by: XinfengZhang carl.zhang@intel.com