refactor(many): upgrade to pnpm 11#2588
Conversation
|
Visual regression report✅ No changes.
Baselines come from the |
also do not allow some dependencies to run scripts for better security. Some dependencies needed to be added because pnpm now has a more strict peer dependency resolution. INSTUI-5064
| "@babel/runtime": "^7.29.2", | ||
| "@babel/standalone": "^7.29.3", | ||
| "codesandbox": "^2.2.3", | ||
| "lorem-ipsum": "^3.0.0", | ||
| "marked-react": "^4.0.0", | ||
| "moment": "^2.30.1", | ||
| "react": "18.3.1", | ||
| "react-dom": "18.3.1", | ||
| "uuid": "^14.0.0", | ||
| "webpack-merge": "^6.0.1" | ||
| "webpack-merge": "^6.0.1", | ||
| "hoist-non-react-statics": "^3.3.2", | ||
| "buffer": "^6.0.3" |
There was a problem hiding this comment.
I needed to add lots of dependencies because in earlier versions pnpm read these if they were in the root node_modules folder, now it needs to be added explicitly. This also uncovered some bugs, e.g. babel runtime not added everywhere
| "pnpm": { | ||
| "overrides": { | ||
| "react": "18.3.1", | ||
| "react-dom": "18.3.1", | ||
| "@types/react": "18.3.26", | ||
| "git-raw-commits>dargs": "7.0.0" | ||
| } | ||
| }, |
There was a problem hiding this comment.
This is now in [pnpm-workspace.yaml
balzss
left a comment
balzss
left a comment
There was a problem hiding this comment.
nice work, works great. pnpm automatically switched to v11 when i run install
| "webpack-dev-server": "^5.2.3", | ||
| "yargs": "^17.7.2" | ||
| "yargs": "^17.7.2", | ||
| "lucide-react": "1.7.0", |
There was a problem hiding this comment.
Why is lucide-react added here?
There was a problem hiding this comment.
i didn't check so i'm not sure but one guess is because of the icon scripts located in ui-scripts import something from the lucide package
|
Please take a look into this issue, upgrade might break something: pnpm/pnpm#11513 |
3 participants
also do not allow some dependencies to run scripts for better security. Some dependencies needed to be added because pnpm now has a more strict peer dependency resolution.
pnpm 11 has lots of good new features:
pnpm-workspace.yml. Please only add here new entries if you checked that its needed and safe (Claude can do this)INSTUI-5064