Repository navigation
chore: sync upstream CI fixes into subagent fallback thinking branch - #1
Merged
inorilzy merged 11 commits intoSep 24, 2026
Merged
Conversation
Cherry-pick PR #1012 with security fixes: - quoteWindowsCmdArg: escape % as %% so cmd.exe does not expand env vars - wrapCmdShim: wrap the /s /c line in outer quotes so paths with spaces survive cmd.exe's first/last quote stripping (prevents injection) - defaultFs.isFile: return false on statSync error instead of existsSync which could match directories - Remove bun/bunx from NODE_LAUNCHERS (dead path: bun has its own install location unrelated to node) fixes #789
style: refine model picker UI
fix(desktop): resolve Windows npx stdio MCP via node and fnm (v2)
fix: model picker light-mode visibility
The .ds-checkbox rule used a hardcoded `border-radius: 4px` which violated the project radius token convention enforced by check-style-tokens.mjs. Replace with `var(--radius-3xs)` (same 4px value) so all border-radius usage goes through the token system.
* fix(docs): restore baseline style and locale gates Restore the missing Chinese design-system table and use the matching radius token so the existing documentation and style gates pass. * feat(settings): keep computer awake while app is running Persist an independent app-suspension setting and own its Electron blocker through startup, setting changes, and shutdown. Cover the Windows system request and the existing display blocker interaction.
Clicking a delegation topology node replaced the whole work-panel tab strip with a single dock overlay, so parallel subagents could not be viewed side by side and every ended detail had to be reopened one at a time. Give subagents a first-class tab kind instead: each delegation opens (or activates) a normal closable tab keyed by its delegation id, so N subagents yield N coexisting tabs with the standard activate, reorder, close, and per-session persistence affordances. No tab opens automatically; ended delegates' tabs stay until closed. The tab renders the delegation as a conversation instead of a summary card: every Task call of the resume chain shows its prompt as a user row and the delegate's thinking, tool, and answer rows beneath it, reusing the main transcript's message-list language, so follow-up prompts read as the next user turn. A disabled two-row composer with an in-field read-only hint closes the tab; display-only by design, since the runtime has no renderer-to-delegate send path. Removes the subagentPanel overlay state, the dock takeover header, and SubagentPanel/SubagentDetail; delegation chain maps are now shared by the topology grouping and the new transcript builder. Specs and E2E plan updated (E2E-248); source-contract tests migrated to the tab model. Co-authored-by: v_wyxgwang <v_wyxgwang@tencent.com>
Use the transparent 30-frame mascot for Chinese locales in dark mode, with a still image for reduced motion. Keep the existing artwork for other locale and theme combinations.
…ding The subagent transcript scroll area had no horizontal padding, so message rows sat flush against the panel edges. Add 16px inline padding to match the reading comfort of the main conversation. The read-only composer textarea at the foot inherited the browser default font size instead of the design-system base. Set font-size to --text-base and line-height to --leading-chat so the disabled field matches the main composer and prose surfaces.
inorilzy
merged commit Sep 24, 2026
b8d36c6
into
inorilzy:feat/subagent-fallback-thinking-inherit-pr
2 of 4 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Integrate
vastsa/PI-Desktop:mainintofeat/subagent-fallback-thinking-inherit-prto repair the checks on upstream PR vastsa#1013.This integration targets the feature branch only, not either repository's
mainbranch. It preserves the existing per-fallback thinking changes and history while incorporating upstream style-token, documentation-locale, and architecture fixes.Validation
The upstream PR's GitHub Actions checks will validate the resulting integration commit.