chore(audience): SDK-317 PR #768 review follow-up#769
Merged
ImmutableJeffrey merged 3 commits intomainfrom May 11, 2026
Merged
Conversation
… (SDK-317) - Adds a TearDown to SampleAppLiveFireTests that resets the two process-globals SetUp mutates. - LogAssert.ignoreFailingMessages goes back to false so a later non-LiveFire fixture in the same test session does not inherit the permissive filter. - ServicePointManager.ServerCertificateValidationCallback goes back to null so the permissive cert validator does not leak to other code that runs in this process. Linear: SDK-317 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…ually ships (SDK-317) - AudienceCiTestMarker_EmitsRunMetadata calls Track but never flushes; the marker sits on the queue and the next test's SetUp deletes the persisted directory before it ever leaves the player. - Replaces the trailing yield-null with FlushAndAssertNoErrors so the marker is sent to the backend and any error rows fail the test. - Test now does what its name claims (emits the marker), not just "did not throw". Linear: SDK-317 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…I artifacts (SDK-317) - The Linux PlayMode container script teed Unity license activation output to /github/workspace/artifacts/activation.log, and the workflow uploads everything under that directory as a downloadable artifact. - Unity's activation log can include sensitive account or entitlement details, so anyone with read access to the workflow run could pull them out of the artifact zip. - Moves ACTIVATION_LOG to /tmp/audience-unity-activation.log. The two grep checks that gate success / failure still read the same file, just from /tmp, and the file never reaches the artifact upload. Linear: SDK-317 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
ImmutableJeffrey
force-pushed
the
chore/sdk-317-pr-768-comments
branch
from
95c8c0d to
5938e50
Compare
nattb8
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reviewer threads addressed on #768
Linear: SDK-317