feat: wire fast-plaid as the plaid optional dependency (#335)#418
Open
MushiSenpai wants to merge 1 commit into
Open
feat: wire fast-plaid as the plaid optional dependency (#335)#418MushiSenpai wants to merge 1 commit into
plaid optional dependency (#335)#418MushiSenpai wants to merge 1 commit into
Conversation
…#335) Per the maintainer note in illuin-tech#335 (the compatibility issues that previously blocked integration are now fixed), expose fast-plaid through a `plaid` optional-dependency group instead of the manual `--no-deps` install in the README. - pyproject.toml: add `plaid = ["fast-plaid>=1.4.7,<2.0.0", "fastkmeans"]` and include it in the `all` group. - README: replace the experimental `--no-deps fast-plaid fastkmeans` snippet with `pip install "colpali-engine[plaid]"` and drop the "experimentally" caveat. fast-plaid 1.4.7.x requires torch==2.11.0, which sits inside the project's existing torch>=2.2.0,<2.12.0 pin. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #335.
In #335, @ManuelFay noted the issues that previously blocked integrating
fast-plaidare now fixed and suggested wiring it in directly:
This does exactly that (the volunteer who offered to take it went quiet a while back,
so I picked it up).
Changes
pyproject.toml— add aplaidoptional-dependency group and include it inall:README.md— replace the experimental manual install(
# !pip install --no-deps fast-plaid fastkmeans) with the supported extra(
pip install "colpali-engine[plaid]") and drop the "experimentally" caveat.Compatibility
fast-plaid1.4.7.x requirestorch==2.11.0, which is inside the project's existingtorch>=2.2.0,<2.12.0pin, and pullsfastkmeans==0.5.0transitively. The PLAIDhelpers (
create_plaid_index/get_topk_plaid) already exist in the codebase — thisonly wires the install path. Happy to tighten or loosen the version bound if you prefer.
Disclosure: drafted with AI assistance (Claude); reviewed, tested, and submitted by me. The commit carries a
Co-Authored-Bytrailer.