Repository navigation
Updated @glimmer/syntax to v0.97 - #372
Conversation
| }, | ||
| "dependencies": { | ||
| "@glimmer/syntax": "^0.95.0" | ||
| "@glimmer/syntax": ">= 0.95.0" |
There was a problem hiding this comment.
In general, I'd prefer writing down the latest version. Would it better to write ^0.97.0 instead (would having multiple copies of @glimmer/syntax be an issue in the end-consumer's project)? I skimmed the changelog and didn't see something resembling a breaking change.
There was a problem hiding this comment.
yes, sure. For a codemod the ecosystem compat of having two versions doesn't matter as much. Changed now.
| '@glimmer/syntax@0.95.0': | ||
| '@glimmer/syntax@0.97.0': | ||
| dependencies: | ||
| '@glimmer/interfaces': 0.94.6 | ||
| '@glimmer/util': 0.94.8 | ||
| '@glimmer/wire-format': 0.94.8 | ||
| '@handlebars/parser': 2.2.2 |
There was a problem hiding this comment.
Nice to see fewer dependencies (these had been moved to devDependencies in emberjs/ember.js#21560).
ijlee2
left a comment
ijlee2
left a comment
There was a problem hiding this comment.
@johanrd Thanks for following up on your contributions to @glimmer/syntax. Just have a question regarding whether to specify ^0.97.0, >= 0.97.0, or >= 0.95.0.
If you have time, can you set up a signature verification? I can still merge the pull request without, but would prefer to see one. Once you have set it up, you may need to recreate your commit (e.g. with git reset --hard HEAD~1 followed by git cherry-pick c94ea92) so that the Verified label appears in the Commits tab.
c94ea92 to
5cbb301
Compare
johanrd
changed the title
Thanks, done. |
Updates
@codemod-utils/ast-templateto@glimmer/syntax0.97.0, which caches newline offsets inSource(emberjs/ember.js#21314, about 20–35% faster template transforms in ember-content-mapper). It is also the first release since 0.95 with types: 0.96.0 shipped without them.The lockfile only swaps the
@glimmer/syntaxentries. The tests ofast-template(151) andast-template-tag(87) pass.🤖 Generated with Claude Code