[MEDIUM] Pin workflow actions to immutable commits - #204
Open
OskarEichler wants to merge 1 commit into
Open
Conversation
Collaborator
|
not sure what to think of this one honestly. I don't see what the ref pinning buys us in this case, vs just setting the version and knowing automatically how behind one is. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Security impact
The release workflow grants id-token: write and delegates package publication to rubygems/release-gem@v1. Mutable action refs can change after review, allowing different third-party code to execute in the publishing boundary without a corresponding http-2 repository diff.
The CI action refs are pinned at the same trust boundary, including the mutable support-simplecov-1 branch.
Verification
rbenv exec bundle exec rake: 448 examples, 0 failures; 41 RuboCop files, no offensesrbenv exec bundle exec rake buildgit diff --checkNo repository tests were changed.
Limitations
Hosted CI, artifact transfer, coverage reporting, and the RubyGems OIDC release were not exercised locally. Workflow inputs, permissions, and selected action revisions are otherwise unchanged.
Breaking changes
None. Runtime code, dependencies, workflow behavior, and selected action versions are unchanged.