Skip to content

The 1.2.2 source gem contains an untracked stale settings.rb #199

Description

@OskarEichler

Summary

The published http-2 1.2.2 source gem does not reproduce tag v1.2.2 (ac8d59014ed282febe5fd096cb3286c32b476db8). It contains lib/http/2/settings.rb, which is absent from the tag, current main, and the clean gemspec result.

Evidence

  • official gem SHA-256: 81b5d45f50fd4cd5f8c5d09651184bec9401e3ef169c3eb3e5b003d5614a92b9
  • official package: 36 paths, including untracked lib/http/2/settings.rb, no license file
  • clean current build: 35 paths, no settings.rb, no license file because the manifest currently names LICENSE.txt
  • clean build with PR Include the license in source gems #198: 36 paths, replacing the stale settings file with the tracked LICENSE

The extra file appears to be residue from the pre-reset implementation (history before bd74873) present in the release build's working tree. It is not loaded by http/2 today, but it makes the source gem non-reproducible and exposes stale code to direct requires.

Suggested follow-up

Ensure the next release is built from a clean checkout and compare its manifest with git ls-files/the gemspec selection. PR #198 separately fixes the license filename.

I used an AI coding assistant during source/package comparison and verification.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions