Repository navigation
Restrict Mermaid diagram template interpolation - #4333
Open
siegfriedpammer wants to merge 1 commit into
Open
siegfriedpammer wants to merge 1 commit into
siegfriedpammer wants to merge 1 commit into
Conversation
Assisted-by: OpenCode:gpt-5.6-luna:OpenCode
dgrunwald
reviewed
Nov 8, 2026
| "{{SourceAssemblyVersion}}" => WebUtility.HtmlEncode(model.SourceAssemblyVersion), | ||
| "{{BuilderVersion}}" => DecompilerVersionInfo.FullVersionWithCommitHash, | ||
| "{{RepoUrl}}" => RepoUrl, | ||
| "{{Model}}" => modelJson, |
Member
There was a problem hiding this comment.
Explain why these other fields don't also need to be encoded.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A crafted assembly can inject HTML and script content into the generated Mermaid diagram page through assembly metadata. Encode HTML-valued fields while preserving the serialized model JSON and trusted repository URL.
Finding: ANT-2026-7PFYC9E7
Verification: the branch formats cleanly. The full build was attempted, but the local reference-assembly annotator cache is missing Microsoft.Build.BackEnd.TaskParameter+TaskParameterTaskItem, so tests could not run locally.
Assisted-by: OpenCode:gpt-5.6-luna:OpenCode