Repository navigation
Bound unresolved generic arities - #4332
Open
siegfriedpammer wants to merge 1 commit into
Open
siegfriedpammer wants to merge 1 commit into
siegfriedpammer wants to merge 1 commit into
Conversation
Unresolved type names and generic signatures can supply attacker-controlled arities that size static caches and temporary argument arrays. Use one practical limit across parsing, dummy parameters, type resolution, and C# AST construction so excessive arities remain bounded before allocation. Assisted-by: OpenCode:gpt-5.6-luna:OpenCode
siegfriedpammer
force-pushed
the
fix/generic-arity-limit
branch
from
November 8, 2026 11:26
40cfbd9 to
45fc553
Compare
Member
|
Is 64 some .NET limitation? If not, that seems unnecessarily low as a limit. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unresolved type names can encode attacker-controlled generic arities such as
Foo40000`. Those values currently size static DummyTypeParameter caches and temporary generic-argument arrays, causing severe memory exhaustion.Use a practical maximum arity of 64 consistently across reflection-name parsing, unknown types, dummy parameter caches, generic type resolution, and C# AST construction. Excessive arities remain unresolved without allocating proportional arrays.
Addresses scan finding ANT-2026-PC9I5I73.
Tests:
OPENSSL_ENABLE_SHA1_SIGNATURES=1 dotnet test --project ICSharpCode.Decompiler.Tests/ICSharpCode.Decompiler.Tests.csproj --no-restore --report-trx --filter "FullyQualifiedName~ReflectionHelperTests|FullyQualifiedName~TypeSystemLoaderTests|FullyQualifiedName~ILPrettyTestRunner.WeirdEnums"(185 passed)