Repository navigation
Bound embedded Portable PDB decompression - #4330
Open
siegfriedpammer wants to merge 1 commit into
Open
siegfriedpammer wants to merge 1 commit into
siegfriedpammer wants to merge 1 commit into
Conversation
Embedded Portable PDB metadata declares its decompressed size before the framework and Cecil readers inflate it. Reject oversized declarations before those readers allocate native or managed memory, keeping symbol loading and debug-directory inspection bounded. Assisted-by: OpenCode:gpt-5.6-luna:OpenCode
siegfriedpammer
force-pushed
the
fix/embedded-pdb-size-limit
branch
from
November 8, 2026 11:26
d980605 to
f173520
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Embedded Portable PDB data declares its decompressed size before the framework and Mono.Cecil readers inflate it. A small crafted assembly can therefore request nearly 2 GiB as soon as it is opened.
Reject declarations over 128 MiB before inflation in ILSpyX symbol loading, PdbDumper, and the metadata debug-directory tree.
Addresses scan finding ANT-2026-JVI3IFUZ.
Tests:
OPENSSL_ENABLE_SHA1_SIGNATURES=1 dotnet test --project ILSpy.Tests/ILSpy.Tests.csproj --no-restore --report-trx --filter "FullyQualifiedName~EmbeddedPdbTreeTests"(2 passed)OPENSSL_ENABLE_SHA1_SIGNATURES=1 dotnet test --project ILSpy.Tests/ILSpy.Tests.csproj --no-restore --report-trx --filter "FullyQualifiedName~PdbDumperTests"(2 passed)