Skip to content

chore: replace deprecated serde_yaml dependency - #1567

Merged
ibigbug merged 1 commit into
ibigbug:masterfrom
lmmqxyx404:codex/replace-serde-yaml-with-yaml-serde
Oct 14, 2026
Merged

ibigbug merged 1 commit into
ibigbug:masterfrom
lmmqxyx404:codex/replace-serde-yaml-with-yaml-serde

Conversation

@lmmqxyx404

@lmmqxyx404 lmmqxyx404 commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

What does this PR do?

Type

  • Bug fix
  • New feature
  • Refactoring / cleanup
  • Other

Checklist

  • Tests added or not needed
  • Docs updated or not needed

Summary by CodeRabbit

  • Chores
    • Updated the app’s internal YAML support.

@coderabbitai

coderabbitai Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 8d4d06ea-6756-4f85-9c92-30596372426a
📥 Commits

Reviewing files that changed from the base of the PR and between 36eec77 and 9f0d94e.

⛔ Files ignored due to path filters: 1
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing: 1
  • clash-lib/Cargo.toml

Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.

📝 Walkthrough

The clash-lib manifest now resolves the serde_yaml dependency name to package yaml_serde version 0.10, replacing package serde_yaml version 0.9.

Changes: YAML dependency update

Layer / File(s) Summary
Update YAML dependency resolution
clash-lib/Cargo.toml
The manifest maps the serde_yaml dependency name to package yaml_serde version 0.10, replacing package serde_yaml version 0.9.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Suggested reviewers: ibigbug

Merge Risk: ⚪ Minimal · up to 9f0d9

The dependency replacement preserves the YAML APIs used by clash-lib, and the lockfile resolves the new package. No material user-facing regression is established; the PR appears ready to merge after normal checks.

Pre-merge checks: Passed 5
Passed Passed checks: 5 passed
Check name Status Explanation
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: replacing the deprecated serde_yaml dependency.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ibigbug ibigbug left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@ibigbug
ibigbug merged commit 6dfe4e1 into ibigbug:master Oct 14, 2026
32 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants